Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci configuration #812

Merged
merged 1 commit into from
Mar 7, 2023
Merged

ci configuration #812

merged 1 commit into from
Mar 7, 2023

Conversation

iyabchen
Copy link
Contributor

@iyabchen iyabchen commented Feb 7, 2023

ci configuration to run in gcp cloud build.

The gcb trigger configuration is in PR: GoogleCloudPlatform/cloud-foundation-toolkit#1398

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly LGTM, just one change request.

@iyabchen iyabchen merged commit b77ae29 into GoogleCloudPlatform:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants