Add serviceDirectoryRegistrations message to resource google_compute_global_forwarding_rule #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…global_forwarding_rule (#9485) * Add serviceDirectoryRegistrations in google_compute_global_forwarding_rule * Add service_directory_registration message in example private_service_connect_google_apis.tf.erb * Remove service field from service_directory_registration message as it is not currently applicable for globalForwardingRule [upstream:087da54a4ca10340c889be9a11487eaa6e93bd99] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
iyabchen
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-087da54a4ca10340c889be9a11487eaa6e93bd99
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
serviceDirectoryRegistrationsmessage to Global Forwarding Rule resource.Fixes hashicorp/terraform-provider-google#9758
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9485