Adding support for new Instance Settings resource and a test into a beta provider. #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eta provider. (#9313) [upstream:f218e989981c0ff81605d43e2095564edbc7116f] Signed-off-by: Modular Magician <[email protected]>
iyabchen
pushed a commit
to iyabchen/terraform-google-conversion
that referenced
this pull request
Nov 8, 2023
…eta provider. (#9313) (GoogleCloudPlatform#1674) [upstream:f218e989981c0ff81605d43e2095564edbc7116f] Signed-off-by: Modular Magician <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background :
Instance Settings is a new GCE compute zonal resource. They are centralized configuration parameters that allow users to configure the default values for specific VM parameters that are normally set using GCE instance API methods. This is a singleton resource (i.e always exists with project and supports only PATCH API).
fixes hashicorp/terraform-provider-google#15748
Changes include:
google_compute_instance_settings.TF_LOG=DEBUG make testacc TEST=./google-beta/services/compute TESTARGS='-run=TestAccComputeInstanceSettings_instanceSettingsBasicExample'Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9313