Use tf dev override in integration test #1588
Conversation
There was a problem hiding this comment.
.ci/cloudbuild-tests-integration.yaml overrides the current version of Terraform to either 0.12.31 or 0.13.7 - but dev overrides require 0.14 or higher. I think we should probably just switch to running these tests on the default Terraform version for go-plus (1.2.5) and remove everything related to the older versions from this repo & from magic-modules (such as https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/containers/go-plus/Dockerfile and https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/gcb-generate-diffs-new.yml)
Attn @ScottSuarez FYI
|
I agree. Supporting multiple terraform versions has been a bit of a pain. If we can eliminate those binaries from the containers I'm all for it. |
There was a problem hiding this comment.
It looks like upgrading the terraform version may require some additional changes to the test files... hopefully it's just the provider statement and it can be done in a way that's backwards-compatible with 0.12/0.13 (so that we wouldn't cause test failures for MM)
Since those tests are removed from integration tests, so it won't break in a rerun. |
tf-dev-override.sh
Outdated
| EOF | ||
| fi | ||
|
|
||
| cp $TF_CONFIG_FILE /tmp/$TF_CONFIG_FILE |
There was a problem hiding this comment.
could we reference the file directly instead of copying it?
No description provided.