Add support for arbitrary commands in formatted executables #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linsword13
reviewed
Sep 6, 2024
This commit allows formatted_executable definitions to have a `commands` attribute, which can define the lines that should be in the formatted output. The default is to format all of the commands for the experiment, but this can be override to format arbitrary strings / variables. Item in the `commands` list will be expanded as a variable definition, and then split over new-lines before formatting based on the formatted executable definition.
douglasjacobsen
force-pushed
the
formatted-executable-control
branch
from
58c464a to
7c3f517
Compare
linsword13
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge allows formatted_executable definitions to have a
commandsattribute, which can define the lines that should be in the formatted output.The default is to format all of the commands for the experiment, but this can be override to format arbitrary strings / variables. Item in the
commandslist will be expanded as a variable definition, and then split over new-lines before formatting based on the formatted executable definition.