Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openfoam application definitions #520

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

douglasjacobsen
Copy link
Collaborator

This merge adds a definition for openfoam.org (called openfoam-org), and updated the previous openfoam application definition to inherit from the openfoam-org definition.

@douglasjacobsen douglasjacobsen added enhancement New feature or request application definition Adds or modifies an application definition labels Jun 3, 2024
@douglasjacobsen douglasjacobsen requested a review from rfbgo June 3, 2024 15:50
rfbgo
rfbgo previously approved these changes Jun 4, 2024
Copy link
Collaborator

@rfbgo rfbgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few notes, mostly already discussed but check out the comment on the FOMs

Happy to merge once tests past (and likely foms addressed)

This commit adds a definition for openfoam.org (called openfoam-org),
and updated the previous openfoam application definition to inherit from
the openfoam-org definition.
@rfbgo rfbgo merged commit f7d2225 into GoogleCloudPlatform:develop Jun 7, 2024
11 checks passed
@douglasjacobsen douglasjacobsen deleted the openfoam_update branch July 8, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application definition Adds or modifies an application definition enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants