Allow workspace_path to be set via config:user:workspace_dir #36
Conversation
|
@dodecatheon Thanks for the contribution! I think we should define a default config value here: https://github.com/GoogleCloudPlatform/ramble/blob/develop/etc/ramble/defaults/config.yaml And then remove the one from I'd also prefer that the name is something that could easily be changed into a list in the future. Maybe something like: |
There was a problem hiding this comment.
That's closer to what I was thinking. You still need to update the schema for config to define this option though.
And I think we probably need at least one test, to make sure changing the workspace dir works in the future.
Also, something in this PR made the dryrun_setup test timeout. So, you might need to look at that.
To run it locally, you can ramble unit-test -k test_dryrun_setup
|
/gcbrun |
…ults in lib/ramble/ramble/config.py and etc/ramble/defaults/config.yaml
workspace_path has been removed, replaced with get_workspace_path and set_workspace_path functions. This had a cascading effect through the unit tests, which overall have been cleaned up to avoid leaving test workspaces around. Changes to be committed: modified: .gitignore modified: lib/ramble/ramble/cmd/workspace.py modified: lib/ramble/ramble/test/cmd/on.py modified: lib/ramble/ramble/test/cmd/workspace.py modified: lib/ramble/ramble/test/conftest.py modified: lib/ramble/ramble/test/end_to_end.py modified: lib/ramble/ramble/test/expander.py modified: lib/ramble/ramble/test/mirror_tests.py modified: lib/ramble/ramble/workspace/__init__.py modified: lib/ramble/ramble/workspace/workspace.py
dodecatheon
force-pushed
the
configurable-workspace-dir
branch
from
9ae72f1 to
22a8762
Compare
|
/gcbrun |
Fix bug introduced by PR #36
Fix bug introduced by PR #36
[pull] develop from GoogleCloudPlatform:develop
This is the simplest possible change -- just change the workspace_path definition to config:user:workspace_dir, if found, otherwise use the old default.