-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: add code samples for model optimizer #13296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add code samples for model optimizer #13296
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yan283, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds a code sample for the model-optimizer-exp-04-09
endpoint using the GenAI API. It includes a new Python file (model_optimizer_textgen_with_txt.py
) containing the code sample and updates the test file (test_text_generation_examples.py
) to include a test case for the new sample.
Highlights
- New Code Sample: Adds a new code sample demonstrating the use of the
model-optimizer-exp-04-09
endpoint for text generation. - Test Integration: Includes a new test case to verify the functionality of the added code sample.
Changelog
- genai/text_generation/model_optimizer_textgen_with_txt.py
- Created a new file with a code sample for the
model-optimizer-exp-04-09
endpoint. - The sample demonstrates how to generate content using the GenAI API.
- The sample uses
genai.Client
to interact with the API. - The sample sends the prompt "How does AI work?" to the model.
- The sample prints the response text to the console.
- Created a new file with a code sample for the
- genai/text_generation/test_text_generation_examples.py
- Imported the new
model_optimizer_textgen_with_txt
module. - Added a new test function
test_model_optimizer_textgen_with_txt
to test the new code sample. - The test function calls the
generate_content
function from the new module and asserts that the response is not empty.
- Imported the new
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A model's mind, optimized,
Generates text, a wondrous prize.
With each new sample,
An example ample,
AI's potential, realized.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds a new code sample for the model-optimizer-exp-04-09 endpoint using the GenAI API. The code sample is well-structured and includes a test case. However, there are a few areas that could be improved for clarity and maintainability.
Summary of Findings
- Model ID Hardcoding: The model ID 'model-optimizer-exp-04-09' is hardcoded in the example. While this is acceptable for a sample, consider adding a comment explaining that this ID is specific to the model optimizer experiment and may change in the future. This will prevent confusion if the sample is used as a template.
- Copyright Year: The copyright year is set to 2025. Please confirm that this is the correct year.
Merge Readiness
The pull request is almost ready for merging. Please address the copyright year and consider adding a comment about the model ID. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
b77b470
to
dca42e5
Compare
@msampathkumar Can you verify that the filename/region tag works with your scheme? |
Description
Add a code sample for the model-optimizer-exp-04-09 endpoint using GenAI API.
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)