-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: update genai textgen_with_pdf.py example #13294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @msampathkumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the textgen_with_pdf.py
example in the genai
directory. The primary goal is to switch the data source from a PDF document about Gemini 1.5 to a different PDF document, presumably to avoid reliance on a specific model version. The change involves updating the file_uri
within the Part.from_uri
function to point to a new PDF file. Additionally, the example response text is updated to reflect the change in the document being summarized.
Highlights
- Data Source Update: The PDF file used for summarization has been changed from
gs://cloud-samples-data/generative-ai/pdf/2403.05530.pdf
(related to Gemini 1.5) togs://cloud-samples-data/generative-ai/pdf/1706.03762v7.pdf
. - Example Response Update: The example response in the comments has been updated to reflect the summarization of the new PDF document, which discusses the Transformer neural network architecture.
Changelog
- genai/text_generation/textgen_with_pdf.py
- Updated the
file_uri
inPart.from_uri
to use a new PDF data source. - Modified the example response to align with the content of the new PDF document.
- Updated the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A PDF's tale,
From Gemini's peak it veers,
To networks anew.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the example code to use a different data source (PDF file) for text generation, as the previous one was specific to the Gemini 1.5 model. The prompt has also been slightly adjusted for clarity. Overall, the changes seem reasonable and address the stated goal.
Merge Readiness
The changes appear straightforward and address the issue of using a Gemini 1.5-specific PDF. Since there are no critical or high severity issues, the pull request seems ready to be merged after addressing the medium severity issue. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
CICD error says - |
Update the code examples to use a different data sources that does not include Gemini 1.5 model. The previous pdf is about Gemini 1.5 model.
bugs: b/407554370