Skip to content

fix: update blur function to match other samples #13293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

fix: update blur function to match other samples #13293

merged 2 commits into from
Apr 8, 2025

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Apr 8, 2025

Description

Fixes #13279

Updates sample to use the Wand equivalent to -blur 0x8, to match other samples.

Potential root cause comment in thread.

Checklist

  • Please merge this PR for me once it is approved

@glasnt glasnt requested review from a team as code owners April 8, 2025 01:51
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses issue #13292 by updating the blur function in the imagemagick samples to align with other samples. Specifically, it modifies the image.resize call to image.blur with a radius of 0 and a sigma of 16, effectively replicating the -blur 0x8 ImageMagick command. The changes are applied to both functions/imagemagick/main.py and functions/v2/imagemagick/main.py.

Highlights

Changelog

  • functions/imagemagick/main.py
    • Replaced image.resize(*image.size, blur=16, filter="hamming") with image.blur(radius=0, sigma=16) to match other samples.
  • functions/v2/imagemagick/main.py
    • Replaced image.resize(*image.size, blur=16, filter="hamming") with image.blur(radius=0, sigma=16) to match other samples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A blur command, refined with care,
Consistency, beyond compare.
Sigma and radius set,
A clearer image, we bet,
With Wand's magic, beyond all snare.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: cloudfunctions Issues related to the Cloud Run functions API. labels Apr 8, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the blur function in two files to use image.blur(radius=0, sigma=16) instead of image.resize(*image.size, blur=16, filter="hamming"). This change aims to align the blur implementation with other samples. The changes look good overall.

Merge Readiness

The code changes appear to be correct and address the issue described in the pull request description. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. Given the changes are straightforward and address a specific issue, the pull request seems ready to be merged.

Copy link
Member

@briandorsey briandorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glasnt glasnt merged commit 47d7704 into main Apr 8, 2025
14 checks passed
@glasnt glasnt deleted the mime branch April 8, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants