Skip to content

fix(generative-ai): Update count tokens sample #11713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2024
Merged

fix(generative-ai): Update count tokens sample #11713

merged 5 commits into from
May 6, 2024

Conversation

holtskinner
Copy link
Contributor

@holtskinner holtskinner commented May 6, 2024 •
edited
Loading

  • Change to new format
  • Add multimodal example

Replacement for #11632

@holtskinner
fix(generative-ai): Update count tokens sample
013a3e8 
- Change to new format
- Add multimodal example
@holtskinner holtskinner requested review from a team as code owners May 6, 2024 19:41
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented May 6, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 6, 2024
@holtskinner holtskinner mentioned this pull request May 6, 2024
Closed
9 tasks
gericdong
gericdong approved these changes May 6, 2024
View reviewed changes
generative_ai/test_gemini_examples.py Outdated
@@ -40,14 +40,14 @@


def test_gemini_guide_example() -> None:
text = gemini_guide_example.generate_text(PROJECT_ID)
text = gemini_guide_example.generate_text(PROJECT_ID, LOCATION)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these samples, all of locations are set to "us-central1". These is no need to pass LOCATION.

@gericdong gericdong merged commit e9d472e into main May 6, 2024
15 checks passed
@gericdong gericdong deleted the vertex-ai-updates branch May 6, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gericdong gericdong gericdong approved these changes

Assignees

@gericdong gericdong

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holtskinner @gericdong