Move function to the only file that uses #1928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelwestphal
requested review from
franciscovalentecastro and
ridwanmsharif
and removed request for
franciscovalentecastro
ridwanmsharif
approved these changes
Apr 9, 2025
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| _, cancel := context.WithCancel(ctx) |
There was a problem hiding this comment.
We don't need this either no?
There was a problem hiding this comment.
ignore me, this whole file will dissapear
| @@ -67,7 +66,7 @@ func run(ctx context.Context) error { | |||
| } | |||
|
|
|||
| func (s *service) Execute(args []string, r <-chan svc.ChangeRequest, changes chan<- svc.Status) (ssec bool, errno uint32) { | |||
| ctx, cancel := context.WithCancel(s.ctx) | |||
There was a problem hiding this comment.
We can prolly get rid of this as well no?
There was a problem hiding this comment.
nvm it doesn't matter, this whole file is disappearing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving function to another directory since that code is going to be deleted.
Related issue
b/409522292
How has this been tested?
Checklist: