Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when checking if PLUGIN test is enabled #1889

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

rafaelwestphal
Copy link
Contributor

Description

Current implementation doesn't work properly if the env variable is exported as an empty string.

Related issue

b/396679776

How has this been tested?

Created a go test sample to verify the behavior

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@rafaelwestphal rafaelwestphal merged commit 3928cf6 into master Feb 14, 2025
11 checks passed
@rafaelwestphal rafaelwestphal deleted the westphalrafael-fix-plugin-env branch February 14, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants