Skip to content

exporter/metric: add WithMetricClient option #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

exporter/metric: add WithMetricClient option #1033

wants to merge 1 commit into from

Conversation

enocom
Copy link
Member

@enocom enocom commented Apr 10, 2025

This commit allows callers to configure their own Cloud Monitoring client.

Fixes #1032

@enocom enocom requested a review from a team as a code owner April 10, 2025 17:07
@enocom
Copy link
Member Author

enocom commented Apr 10, 2025

cc @ridwanmsharif

@enocom
exporter/metric: add WithMetricClient option
a7bcda4 
This commit allows callers to configure their own Cloud Monitoring
client.

Fixes GoogleCloudPlatform#1032
@enocom
Copy link
Member Author

enocom commented Apr 10, 2025

The test failures look unrelated to this change.

@enocom enocom mentioned this pull request Apr 10, 2025
Open
ridwanmsharif
ridwanmsharif reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor

@ridwanmsharif ridwanmsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give some examples of why this is useful, I'm wondering what settings were useful that weren't already settable with the WithMonitoringClientOptions option

@enocom
Copy link
Member Author

enocom commented Apr 11, 2025

Let's move the discussion here for better discoverability: #1032.

@enocom enocom mentioned this pull request Apr 11, 2025
Open
ridwanmsharif
ridwanmsharif approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@ridwanmsharif ridwanmsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the explanation, sounds reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridwanmsharif ridwanmsharif ridwanmsharif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exporter/metric: Allow callers to provide a Cloud Monitoring client
2 participants
@enocom @ridwanmsharif