Add Spanner stale read sample. #475
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,103 +53,139 @@ test.after.always(async (t) => { | |
|
|
||
| // create_database | ||
| test.serial(`should create an example database`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${schemaCmd} createDatabase "${INSTANCE_ID}" "${DATABASE_ID}"`, cwd); | ||
|
There was a problem hiding this comment. What's the point of this? (Having
There was a problem hiding this comment. I've discover lately that sometimes tests/commands fail silently (return a 0 exit code), but do print some useful info to stderr. This improves test debuggability. |
||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`Waiting for operation on ${DATABASE_ID} to complete...`)); | ||
| t.regex(output, new RegExp(`Created database ${DATABASE_ID} on instance ${INSTANCE_ID}.`)); | ||
| }); | ||
|
|
||
| // insert_data | ||
| test.serial(`should insert rows into an example table`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${crudCmd} insert ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`Inserted data.`)); | ||
|
There was a problem hiding this comment. Replace |
||
| }); | ||
|
|
||
| // query_data | ||
| test.serial(`should query an example table and return matching rows`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${crudCmd} query ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`SingerId: 1, AlbumId: 1, AlbumTitle: Go, Go, Go`)); | ||
| }); | ||
|
|
||
| // read_data | ||
| test.serial(`should read an example table`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${crudCmd} read ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`SingerId: 1, AlbumId: 1, AlbumTitle: Go, Go, Go`)); | ||
| }); | ||
|
|
||
| // add_column | ||
| test.serial(`should add a column to a table`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${schemaCmd} addColumn ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`Waiting for operation to complete...`)); | ||
| t.regex(output, new RegExp(`Added the MarketingBudget column.`)); | ||
| }); | ||
|
|
||
| // update_data | ||
| test.serial(`should update existing rows in an example table`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${crudCmd} update ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`Updated data.`)); | ||
| }); | ||
|
|
||
| // read_stale_data | ||
| test.serial(`should read stale data from an example table`, (t) => { | ||
| t.plan(2); | ||
| // read-stale-data reads data that is exactly 10 seconds old. So, make sure | ||
| // 10 seconds have elapsed since the update_data test. | ||
| return new Promise((resolve, reject) => { | ||
| setTimeout(async () => { | ||
|
There was a problem hiding this comment. Nit: can you promisify the |
||
| const results = await tools.runAsyncWithIO(`${crudCmd} read-stale ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| try { | ||
| t.regex(output, new RegExp(`SingerId: 1, AlbumId: 1, AlbumTitle: Go, Go, Go, MarketingBudget: 100000`)); | ||
| t.regex(output, new RegExp(`SingerId: 2, AlbumId: 2, AlbumTitle: Forever Hold your Peace, MarketingBudget: 500000`)); | ||
| resolve(); | ||
| } catch (err) { | ||
| reject(err); | ||
| } | ||
| }, 11000); | ||
| }); | ||
| }); | ||
|
|
||
| // query_data_with_new_column | ||
| test.serial(`should query an example table with an additional column and return matching rows`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${schemaCmd} queryNewColumn ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`SingerId: 1, AlbumId: 1, MarketingBudget: 100000`)); | ||
| t.regex(output, new RegExp(`SingerId: 2, AlbumId: 2, MarketingBudget: 500000`)); | ||
| }); | ||
|
|
||
| // create_index | ||
| test.serial(`should create an index in an example table`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${indexingCmd} createIndex ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`Waiting for operation to complete...`)); | ||
| t.regex(output, new RegExp(`Added the AlbumsByAlbumTitle index.`)); | ||
| }); | ||
|
|
||
| // create_storing_index | ||
| test.serial(`should create a storing index in an example table`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${indexingCmd} createStoringIndex ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`Waiting for operation to complete...`)); | ||
| t.regex(output, new RegExp(`Added the AlbumsByAlbumTitle2 index.`)); | ||
| }); | ||
|
|
||
| // query_data_with_index | ||
| test.serial(`should query an example table with an index and return matching rows`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${indexingCmd} queryIndex ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`AlbumId: 1, AlbumTitle: Go, Go, Go, MarketingBudget:`)); | ||
| t.false(output.includes(`AlbumId: 2, AlbumTitle: Total Junk, MarketingBudget:`)); | ||
| }); | ||
|
|
||
| test.serial(`should respect query boundaries when querying an example table with an index`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${indexingCmd} queryIndex ${INSTANCE_ID} ${DATABASE_ID} -s Ardvark -e Zoo`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`AlbumId: 1, AlbumTitle: Go, Go, Go, MarketingBudget:`)); | ||
| t.regex(output, new RegExp(`AlbumId: 2, AlbumTitle: Total Junk, MarketingBudget:`)); | ||
| }); | ||
|
|
||
| // read_data_with_index | ||
| test.serial(`should read an example table with an index`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${indexingCmd} readIndex ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`AlbumId: 1, AlbumTitle: Go, Go, Go`)); | ||
| }); | ||
|
|
||
| // read_data_with_storing_index | ||
| test.serial(`should read an example table with a storing index`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${indexingCmd} readStoringIndex ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`AlbumId: 1, AlbumTitle: Go, Go, Go`)); | ||
| }); | ||
|
|
||
| // read_only_transaction | ||
| test.serial(`should read an example table using transactions`, async (t) => { | ||
| const results = await tools.runAsyncWithIO(`${transactionCmd} readOnly ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| const output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`SingerId: 1, AlbumId: 1, AlbumTitle: Go, Go, Go`)); | ||
| t.regex(output, new RegExp(`Successfully executed read-only transaction.`)); | ||
| }); | ||
|
|
||
| // read_write_transaction | ||
| test.serial(`should read from and write to an example table using transactions`, async (t) => { | ||
| let results = await tools.runAsyncWithIO(`${transactionCmd} readWrite ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| let output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`The first album's marketing budget: 100000`)); | ||
| t.regex(output, new RegExp(`The second album's marketing budget: 500000`)); | ||
| t.regex(output, new RegExp(`Successfully executed read-write transaction to transfer 200000 from Album 2 to Album 1.`)); | ||
|
|
||
| results = await tools.runAsyncWithIO(`${schemaCmd} queryNewColumn ${INSTANCE_ID} ${DATABASE_ID}`, cwd); | ||
| output = results.stdout + results.stderr; | ||
| t.regex(output, new RegExp(`SingerId: 1, AlbumId: 1, MarketingBudget: 300000`)); | ||
| t.regex(output, new RegExp(`SingerId: 2, AlbumId: 2, MarketingBudget: 300000`)); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: inconsistent comment tense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done