-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(markdown-preview): Migrate editor and renderer services to ESM #4065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @hivanalejandro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request migrates the editor and renderer services to ESM (ECMAScript Modules) by adding the type: module
field to the package.json
files for both the editor and renderer directories. This change enables the use of modern JavaScript module syntax (import/export) within these services. The PR addresses the issue b/253601199.
Highlights
- Migration to ESM: The primary goal of this PR is to migrate the editor and renderer services to ESM.
- package.json modification: The
package.json
files in both theeditor
andrenderer
directories are updated to includetype: module
.
Changelog
- run/markdown-preview/editor/package.json
- Added
type: module
to enable ESM support. - Ensured the file ends with a newline character.
- Added
- run/markdown-preview/renderer/package.json
- Added
type: module
to enable ESM support. - Ensured the file ends with a newline character.
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
ESM's the way,
Modules shine so bright today,
Code's future call.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates the editor and renderer services to ESM by adding type: module
to their respective package.json
files. The changes are straightforward and seem correct. I have a few minor suggestions.
Merge Readiness
The pull request appears to be in good shape for merging. The changes are simple and directly address the stated goal of migrating the editor and renderer services to ESM. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.
Description
Fixes b/253601199
Checklist
npm test
(see Testing)npm run lint
(see Style)