Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): migrate sqlserver/mssql sample to new ci #4056

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Apr 1, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Sorry, something went wrong.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request migrates the mssql samples to the new CI system. This involves changes to the CI configuration files and updates to the package.json files for both the mssql and tedious samples. Specifically, the PR adds ci-setup.json files for mssql and tedious, removes these samples from the production CI configuration, and adds them to the development CI configuration. It also adds a proxy script to the package.json files to run the SQL proxy during system tests.

Highlights

  • CI Migration: The primary goal is to migrate the mssql samples to the new CI system, ensuring they are tested and validated in the CI pipeline.
  • Configuration Changes: Updates to .github/config/nodejs-dev.jsonc and .github/config/nodejs-prod.jsonc to reflect the new CI setup.
  • New CI Setup Files: Addition of ci-setup.json files for both mssql and tedious samples, defining the necessary environment variables and secrets for CI.
  • Package.json Updates: Modification of package.json files to include a proxy script for running the SQL proxy during system tests.

Changelog

Click here to see the changelog
  • .github/config/nodejs-dev.jsonc
    • Added cloud-sql/sqlserver/mssql to line 104.
    • Added cloud-sql/sqlserver/tedious to line 105.
  • .github/config/nodejs-prod.jsonc
    • Removed cloud-sql/sqlserver/mssql from line 82.
    • Removed cloud-sql/sqlserver/tedious from line 83.
  • cloud-sql/sqlserver/mssql/ci-setup.json
    • Created new file to define CI environment variables and secrets for the mssql sample.
  • cloud-sql/sqlserver/mssql/package.json
    • Added proxy script to run the SQL proxy during system tests on line 16.
    • Modified system-test script to use the proxy script on line 17.
  • cloud-sql/sqlserver/tedious/ci-setup.json
    • Created new file to define CI environment variables and secrets for the tedious sample.
  • cloud-sql/sqlserver/tedious/package.json
    • Added proxy script to run the SQL proxy during system tests on line 16.
    • Modified system-test script to use the proxy script on line 17.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Did you know?

SQL Server was originally developed by Sybase and Microsoft in the late 1980s.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: cloudsql Issues related to the Cloud SQL for MySQL API. asset: pattern DEE Asset tagging - Pattern. labels Apr 1, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request migrates the mssql samples to the new CI. This involves adding the samples to the nodejs-dev.jsonc config file, removing them from the nodejs-prod.jsonc file, and adding ci-setup.json and updating package.json files for both mssql and tedious samples. The changes look good overall.

Merge Readiness

The changes look good and the pull request seems ready to be merged. I am unable to directly approve the pull request, so please have others review and approve this code before merging.

glasnt added 5 commits April 7, 2025 12:01
@glasnt glasnt changed the title chore(ci): migrate mssql samples to new ci chore(ci): migrate sqlserver/mssql sample to new ci Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudsql Issues related to the Cloud SQL for MySQL API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant