-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): migrate sqlserver/mssql sample to new ci #4056
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request migrates the mssql samples to the new CI system. This involves changes to the CI configuration files and updates to the package.json
files for both the mssql
and tedious
samples. Specifically, the PR adds ci-setup.json
files for mssql
and tedious
, removes these samples from the production CI configuration, and adds them to the development CI configuration. It also adds a proxy
script to the package.json
files to run the SQL proxy during system tests.
Highlights
- CI Migration: The primary goal is to migrate the mssql samples to the new CI system, ensuring they are tested and validated in the CI pipeline.
- Configuration Changes: Updates to
.github/config/nodejs-dev.jsonc
and.github/config/nodejs-prod.jsonc
to reflect the new CI setup. - New CI Setup Files: Addition of
ci-setup.json
files for bothmssql
andtedious
samples, defining the necessary environment variables and secrets for CI. - Package.json Updates: Modification of
package.json
files to include aproxy
script for running the SQL proxy during system tests.
Changelog
Click here to see the changelog
- .github/config/nodejs-dev.jsonc
- Added
cloud-sql/sqlserver/mssql
to line 104. - Added
cloud-sql/sqlserver/tedious
to line 105.
- Added
- .github/config/nodejs-prod.jsonc
- Removed
cloud-sql/sqlserver/mssql
from line 82. - Removed
cloud-sql/sqlserver/tedious
from line 83.
- Removed
- cloud-sql/sqlserver/mssql/ci-setup.json
- Created new file to define CI environment variables and secrets for the
mssql
sample.
- Created new file to define CI environment variables and secrets for the
- cloud-sql/sqlserver/mssql/package.json
- Added
proxy
script to run the SQL proxy during system tests on line 16. - Modified
system-test
script to use theproxy
script on line 17.
- Added
- cloud-sql/sqlserver/tedious/ci-setup.json
- Created new file to define CI environment variables and secrets for the
tedious
sample.
- Created new file to define CI environment variables and secrets for the
- cloud-sql/sqlserver/tedious/package.json
- Added
proxy
script to run the SQL proxy during system tests on line 16. - Modified
system-test
script to use theproxy
script on line 17.
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
SQL Server was originally developed by Sybase and Microsoft in the late 1980s.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request migrates the mssql samples to the new CI. This involves adding the samples to the nodejs-dev.jsonc
config file, removing them from the nodejs-prod.jsonc
file, and adding ci-setup.json
and updating package.json
files for both mssql
and tedious
samples. The changes look good overall.
Merge Readiness
The changes look good and the pull request seems ready to be merged. I am unable to directly approve the pull request, so please have others review and approve this code before merging.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.