Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: manually updating puppeteer and google-github-actions/auth action to v1.1.1 from forked renovate #3209

Merged
merged 13 commits into from
May 16, 2023

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented May 10, 2023

Description

Origin PRs:

Screenshot 2023-05-10 at 4 15 36 PM

Last sentence in error above from PR 3206 , google-github-actions/auth seems to error out if job is initiated via forked version. Updating this manually.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@pattishin pattishin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 10, 2023
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels May 10, 2023
@pattishin pattishin changed the title fix: updating permissions in vision workflow 🚧 fix: updating permissions in vision workflow 🚧 (wip) May 10, 2023
@pattishin pattishin changed the title fix: updating permissions in vision workflow 🚧 (wip) chore: manually updating google-github-actions/auth action to v1.1.1 from forked renovate May 10, 2023
@pattishin pattishin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 10, 2023
@pattishin pattishin changed the title chore: manually updating google-github-actions/auth action to v1.1.1 from forked renovate chore: manually updating puppeteer and google-github-actions/auth action to v1.1.1 from forked renovate May 10, 2023
@pattishin pattishin marked this pull request as ready for review May 10, 2023 23:52
@pattishin pattishin requested review from a team as code owners May 10, 2023 23:52
@pattishin
Copy link
Contributor Author

Looking into dialogflow-cx test failure.

@kweinmeister
Copy link
Collaborator

Hi @pattishin , thanks for taking care of this!

Just FYI, the way CI is currently configured, we can ignore these pull_request failures if the matching pull_request_target is passing.

The pull_request_target actually does setup permissions properly on forks. However, we should manually inspect any forked PRs for security reasons. If it looks good, we can then apply the actions: force run label to trigger the PR target check.

We have an open issue #2891 filed to cleanup this workflow.

@kweinmeister
Copy link
Collaborator

The dialogflow-cx error looks like an unrelated flaky test, but I do think we need to fix this blocking issue: #3158 to make sure the Puppeteer upgrade is working correctly. Notice the error on run/websockets.

@pattishin
Copy link
Contributor Author

Thanks @kweinmeister! Checking it out 👍🏼

@pattishin pattishin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2023
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 12, 2023
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2023
@pattishin pattishin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2023
@pattishin pattishin enabled auto-merge (squash) May 13, 2023 01:34
@pattishin pattishin merged commit 24e173f into main May 16, 2023
@pattishin pattishin deleted the fix/workflows-error branch May 16, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants