Skip to content

enable xprof #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025
Merged

enable xprof #692

merged 5 commits into from
Apr 25, 2025

Conversation

Doris26
Copy link
Collaborator

@Doris26 Doris26 commented Apr 24, 2025

Description

enable xprof dump to cns for sample run

Tests

sample run log: https://paste.googleplex.com/6018539636654080
xprof loaded in cns: https://screenshot.googleplex.com/8MrfLKfzCQwe63i
dags are working as before: https://screenshot.googleplex.com/AqUHyGuiht9i4QR

List links for your tests (use go/shortn-gen for any internal link): ...

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@wang2yn84 wang2yn84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Left couple of comments.

@wang2yn84
Copy link
Collaborator

Please add copyright section to all the new files.

Copy link
Collaborator

@wang2yn84 wang2yn84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Doris26 Doris26 merged commit 3f0c752 into master Apr 25, 2025
6 checks passed
@Doris26 Doris26 deleted the xprof branch April 25, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants