Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split test in prod or dev environment for resource limitation #551

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Split test in prod or dev environment for resource limitation #551

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe91309
Update run_mantaray_jobs.py
ManfeiBai Jan 14, 2025
0df9100
Update run_mantaray_jobs.py
ManfeiBai Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dags/mantaray/run_mantaray_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
# merge all PyTorch/XLA tests ino one Dag
with models.DAG(
dag_id="pytorch_xla_model_regression_test_on_trillium",
schedule="0 0 * * *", # everyday at midnight # job["schedule"],
schedule="0 0 * * *" if composer_env.is_prod_env() else None, # everyday at midnight # job["schedule"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, @RissyRan, due to other test might been set with different schedule time, so I only update test for pytorch_xla_model_regression_test_on_trillium, and please let me know if I missed anything

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you upload to an test env, and see if other child dags get benefit? I think it should work properly.

tags=["mantaray", "pytorchxla", "xlml"],
start_date=datetime.datetime(2024, 4, 22),
catchup=False,
Expand Down
Loading