-
Notifications
You must be signed in to change notification settings - Fork 2k
Update Gemini GeminiGcpEnablementSetting resource -- add the web_grounding_type field #14443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gemini GeminiGcpEnablementSetting resource -- add the web_grounding_type field #14443
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 20 Click here to see the affected service packages
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommending an official deprecation. Can you also update the release notes accordingly following https://googlecloudplatform.github.io/magic-modules/code-review/release-notes/
@@ -4,4 +4,5 @@ resource "google_gemini_gemini_gcp_enablement_setting" "{{$.PrimaryResourceId}}" | |||
labels = {"my_key": "my_value"} | |||
enable_customer_data_sharing = true | |||
disable_web_grounding = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should remove disable_web_grounding
from these examples right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ✅
da4e6e2
to
68b0f0c
Compare
Deprecate the `disableWebGrounding` field. Co-authored-by: Cameron Thornton <[email protected]>
68b0f0c
to
5ef9df5
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gemini_gemini_gcp_enablement_setting" "primary" {
disable_web_grounding = # value needed
}
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gemini_gemini_gcp_enablement_setting" "primary" {
disable_web_grounding = # value needed
}
|
Tests analyticsTotal tests: 20 Click here to see the affected service packages
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
Tests analyticsTotal tests: 20 Click here to see the affected service packages
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the updates! LGTM
7d01cba
…nding_type field (GoogleCloudPlatform#14443) Co-authored-by: Cameron Thornton <[email protected]>
…nding_type field (GoogleCloudPlatform#14443) Co-authored-by: Cameron Thornton <[email protected]>
…nding_type field (GoogleCloudPlatform#14443) Co-authored-by: Cameron Thornton <[email protected]>
…nding_type field (GoogleCloudPlatform#14443) Co-authored-by: Cameron Thornton <[email protected]>
…nding_type field (GoogleCloudPlatform#14443) Co-authored-by: Cameron Thornton <[email protected]>
…nding_type field (GoogleCloudPlatform#14443) Co-authored-by: Cameron Thornton <[email protected]>
…nding_type field (GoogleCloudPlatform#14443) Co-authored-by: Cameron Thornton <[email protected]>
…nding_type field (GoogleCloudPlatform#14443) Co-authored-by: Cameron Thornton <[email protected]>
…nding_type field (GoogleCloudPlatform#14443) Co-authored-by: Cameron Thornton <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.