Skip to content

Update Gemini GeminiGcpEnablementSetting resource -- add the web_grounding_type field #14443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mwiatrowski
Copy link
Contributor

@mwiatrowski mwiatrowski commented Jul 2, 2025

gemini: added `web_grounding_type` field to `google_gemini_gemini_gcp_enablement_setting` resource
gemini: deprecated the `disable_web_grounding` field in the `google_gemini_gemini_gcp_enablement_setting` resource 

@github-actions github-actions bot requested a review from c2thorn July 2, 2025 12:09
Copy link

github-actions bot commented Jul 2, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 55 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 7 files changed, 55 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 17
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • gemini
#### Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiGeminiGcpEnablementSettingBinding_update
  • TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample
  • TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccGeminiGeminiGcpEnablementSettingBinding_update [Debug log]
TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample [Debug log]
TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link

github-actions bot commented Jul 7, 2025

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Jul 9, 2025

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommending an official deprecation. Can you also update the release notes accordingly following https://googlecloudplatform.github.io/magic-modules/code-review/release-notes/

@@ -4,4 +4,5 @@ resource "google_gemini_gemini_gcp_enablement_setting" "{{$.PrimaryResourceId}}"
labels = {"my_key": "my_value"}
enable_customer_data_sharing = true
disable_web_grounding = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove disable_web_grounding from these examples right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

@github-actions github-actions bot requested a review from c2thorn July 11, 2025 07:28
@mwiatrowski mwiatrowski force-pushed the wiatrowskim-web-grounding-type branch from da4e6e2 to 68b0f0c Compare July 11, 2025 09:52
Deprecate the `disableWebGrounding` field.

Co-authored-by: Cameron Thornton <[email protected]>
@mwiatrowski mwiatrowski force-pushed the wiatrowskim-web-grounding-type branch from 68b0f0c to 5ef9df5 Compare July 11, 2025 09:55
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 54 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 7 files changed, 54 insertions(+), 8 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_gemini_gcp_enablement_setting (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_gemini_gcp_enablement_setting" "primary" {
  disable_web_grounding = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 54 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 7 files changed, 54 insertions(+), 8 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_gemini_gcp_enablement_setting (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_gemini_gcp_enablement_setting" "primary" {
  disable_web_grounding = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 17
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • gemini
#### Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiGeminiGcpEnablementSettingBinding_update
  • TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample
  • TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccGeminiGeminiGcpEnablementSettingBinding_update [Debug log]
TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample [Debug log]
TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 17
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • gemini
#### Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiGeminiGcpEnablementSettingBinding_update
  • TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample
  • TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccGeminiGeminiGcpEnablementSettingBinding_update [Debug log]
TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample [Debug log]
TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the updates! LGTM

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants