Skip to content

fix invalid build_config.worker_pool in cloudrunv2 example and test #14291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

dixuswe
Copy link
Contributor

@dixuswe dixuswe commented Jun 17, 2025

This is to fix failed acceptance tests TestAccCloudRunV2Service

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@github-actions github-actions bot requested a review from ScottSuarez June 17, 2025 21:31
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 4 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 deletion(-))

@modular-magician modular-magician requested a review from ian-mi June 17, 2025 21:44
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 79
Passed tests: 69
Skipped tests: 8
Affected tests: 2

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample
  • TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@ScottSuarez ScottSuarez enabled auto-merge June 18, 2025 16:24
@ScottSuarez ScottSuarez disabled auto-merge June 18, 2025 16:24
Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but will give time for @ian-mi to review

@ScottSuarez ScottSuarez added this pull request to the merge queue Jun 24, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 25f18d7 Jun 24, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants