Skip to content

Promote CustomErrorResponsePolicy from beta #14270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025

Conversation

pradeepcrao
Copy link
Contributor

@pradeepcrao pradeepcrao commented Jun 13, 2025

The Custom Error Responses feature is GA, so this change promotes it from beta.

compute: promoted `default_custom_error_response_policy` to GA in `google_compute_url_map`

@github-actions github-actions bot requested a review from c2thorn June 13, 2025 15:48
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 951 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1062 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 2 files changed, 5 insertions(+), 15 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 182 insertions(+))

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccComputeUrlMap_urlMapCustomErrorResponsePolicyExample

Tests analytics

Total tests: 1224
Passed tests: 1141
Skipped tests: 83
Affected tests: 0

Click here to see the affected service packages
  • compute
🟢 All tests passed!

View the build log

@c2thorn
Copy link
Member

c2thorn commented Jun 13, 2025

tests passed in GA env

@c2thorn c2thorn added this pull request to the merge queue Jun 13, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 36ad8bc Jun 13, 2025
25 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Jun 16, 2025
kautikdk pushed a commit to kautikdk/magic-modules that referenced this pull request Jun 18, 2025
G-jackyli pushed a commit to G-jackyli/magic-modules that referenced this pull request Jun 21, 2025
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Jun 23, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants