Add `google_beyondcorp_security_gateway_application` resource. #13918

Berro321 · 2025-05-12T22:49:44Z

`google_beyondcorp_security_gateway_application`

modular-magician · 2025-05-12T23:02:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2542 insertions(+), 93 deletions(-))
google-beta provider: Diff ( 10 files changed, 2452 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_beyondcorp_security_gateway_application (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_beyondcorp_security_gateway_application" "primary" {
  display_name = # value needed
  endpoint_matchers {
    ports = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_beyondcorp_security_gateway_application_iam_binding
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_member
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_policy
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]

modular-magician · 2025-05-12T23:03:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2542 insertions(+), 93 deletions(-))
google-beta provider: Diff ( 10 files changed, 2452 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_beyondcorp_security_gateway_application (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_beyondcorp_security_gateway_application" "primary" {
  display_name = # value needed
  endpoint_matchers {
    ports = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_beyondcorp_security_gateway_application_iam_binding
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_member
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_policy
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]

modular-magician · 2025-05-12T23:06:21Z

Tests analytics

Total tests: 50
Passed tests: 35
Skipped tests: 6
Affected tests: 9

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-12T23:07:29Z

Tests analytics

Total tests: 50
Passed tests: 35
Skipped tests: 6
Affected tests: 9

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-12T23:21:19Z

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-12T23:22:18Z

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-12T23:42:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2542 insertions(+), 93 deletions(-))
google-beta provider: Diff ( 10 files changed, 2452 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_beyondcorp_security_gateway_application (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_beyondcorp_security_gateway_application" "primary" {
  display_name = # value needed
  endpoint_matchers {
    ports = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_beyondcorp_security_gateway_application_iam_binding
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_member
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_policy
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]

modular-magician · 2025-05-12T23:45:47Z

Tests analytics

Total tests: 50
Passed tests: 43
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-12T23:51:23Z

🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-13T01:31:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2542 insertions(+), 93 deletions(-))
google-beta provider: Diff ( 10 files changed, 2452 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_beyondcorp_security_gateway_application (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_beyondcorp_security_gateway_application" "primary" {
  display_name = # value needed
  endpoint_matchers {
    ports = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_beyondcorp_security_gateway_application_iam_binding
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_member
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_policy
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]

modular-magician · 2025-05-13T01:34:41Z

Tests analytics

Total tests: 50
Passed tests: 43
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-13T01:40:26Z

🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-13T02:28:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2542 insertions(+), 93 deletions(-))
google-beta provider: Diff ( 10 files changed, 2452 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_beyondcorp_security_gateway_application (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_beyondcorp_security_gateway_application" "primary" {
  display_name = # value needed
  endpoint_matchers {
    ports = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_beyondcorp_security_gateway_application_iam_binding
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_member
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_policy
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]

modular-magician · 2025-05-13T02:32:32Z

Tests analytics

Total tests: 50
Passed tests: 37
Skipped tests: 6
Affected tests: 7

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-13T02:38:30Z

🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

application resource.

modular-magician · 2025-05-13T17:32:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2542 insertions(+), 93 deletions(-))
google-beta provider: Diff ( 10 files changed, 2452 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_beyondcorp_security_gateway_application (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_beyondcorp_security_gateway_application" "primary" {
  display_name = # value needed
  endpoint_matchers {
    ports = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_beyondcorp_security_gateway_application_iam_binding
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_member
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_policy
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]

modular-magician · 2025-05-13T17:36:02Z

Tests analytics

Total tests: 50
Passed tests: 35
Skipped tests: 6
Affected tests: 9

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-13T17:44:24Z

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-14T04:31:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2542 insertions(+), 93 deletions(-))
google-beta provider: Diff ( 10 files changed, 2452 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_beyondcorp_security_gateway_application (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_beyondcorp_security_gateway_application" "primary" {
  display_name = # value needed
  endpoint_matchers {
    ports = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_beyondcorp_security_gateway_application_iam_binding
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_member
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]
google_beyondcorp_security_gateway_application_iam_policy
- Expected Document Path: /website/docs/r/beyondcorp_security_gateway_application_iam.html.markdown
- Fields: [application_id security_gateways_id]

modular-magician · 2025-05-14T04:35:12Z

Tests analytics

Total tests: 50
Passed tests: 37
Skipped tests: 6
Affected tests: 7

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-14T04:41:44Z

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-16T17:44:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2560 insertions(+), 94 deletions(-))
google-beta provider: Diff ( 10 files changed, 2469 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_beyondcorp_security_gateway_application, google_beyondcorp_security_gateway_application_iam_binding, google_beyondcorp_security_gateway_application_iam_member, google_beyondcorp_security_gateway_application_iam_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2025-05-16T17:48:48Z

Tests analytics

Total tests: 52
Passed tests: 45
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-16T17:55:10Z

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

Berro321 · 2025-05-16T17:55:26Z

@SirGitsalot Is the multiple-resources error because of the IAM resources also contained in this change? If so, can we still submit this PR or is there something else needed from me?

SirGitsalot · 2025-05-16T21:15:02Z

/gcbrun

SirGitsalot · 2025-05-16T21:22:17Z

Yeah, it's the IAM resources but that's fine - I've added the necessary label to override the check.

modular-magician · 2025-05-16T21:28:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2560 insertions(+), 94 deletions(-))
google-beta provider: Diff ( 10 files changed, 2469 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_beyondcorp_security_gateway_application, google_beyondcorp_security_gateway_application_iam_binding, google_beyondcorp_security_gateway_application_iam_member, google_beyondcorp_security_gateway_application_iam_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2025-05-16T21:31:43Z

Tests analytics

Total tests: 52
Passed tests: 46
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition
🟢 All tests passed!

View the build log

mmv1/products/beyondcorp/SecurityGatewayApplication.yaml

Berro321 · 2025-05-19T20:44:46Z

friendly ping for review

mmv1/products/beyondcorp/SecurityGatewayApplication.yaml

NickElliot · 2025-05-20T17:02:05Z

Hi going to drive-by for a moment here: because this resource isn't merged yet we're modifying the deprecation message on beyondcorp_application #13991 to avoid suggesting using this (unreleased) resource for the release this week.

if you could restore the current full-length deprecation message along with the rest of this PR, that would be great thanks!

modular-magician · 2025-05-20T19:18:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 2562 insertions(+), 96 deletions(-))
google-beta provider: Diff ( 12 files changed, 2471 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_beyondcorp_security_gateway_application, google_beyondcorp_security_gateway_application_iam_binding, google_beyondcorp_security_gateway_application_iam_member, google_beyondcorp_security_gateway_application_iam_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2025-05-20T19:18:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 2562 insertions(+), 96 deletions(-))
google-beta provider: Diff ( 12 files changed, 2471 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 568 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_beyondcorp_security_gateway_application, google_beyondcorp_security_gateway_application_iam_binding, google_beyondcorp_security_gateway_application_iam_member, google_beyondcorp_security_gateway_application_iam_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2025-05-20T19:21:28Z

Tests analytics

Total tests: 52
Passed tests: 46
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition
🟢 All tests passed!

View the build log

modular-magician · 2025-05-20T19:22:31Z

Tests analytics

Total tests: 52
Passed tests: 46
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withAndWithoutCondition
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withAndWithoutCondition
🟢 All tests passed!

View the build log

Berro321 added 2 commits May 12, 2025 22:47

Add SecurityGatewayApplication resource.

6736834

Add EOF to yaml

525af15

modular-magician added the service/beyondcorp label May 12, 2025

Slightly rename test names.

8895a03

Rename some tests.

8437595

Rename SG application test names in resource.

b15031f

Update to unique test names from existing

e0a5261

application resource.

add prefix to iam test

e0482e7

Fix misnamed test.

676bc57

Add ports field to test

4f3c094

SirGitsalot added the override-multiple-resources Allow a PR to contain multiple new resources label May 16, 2025

SirGitsalot reviewed May 16, 2025

View reviewed changes

mmv1/products/beyondcorp/SecurityGatewayApplication.yaml Show resolved Hide resolved

Berro321 requested a review from SirGitsalot May 16, 2025 23:19

SirGitsalot requested changes May 19, 2025

View reviewed changes

mmv1/products/beyondcorp/SecurityGatewayApplication.yaml Show resolved Hide resolved

Berro321 added 2 commits May 20, 2025 19:05

Merge remote-tracking branch 'origin/main' into beyondcorp-rename

9ae3a97

Update application deprecation message.

0bd49dc

github-actions bot requested a review from SirGitsalot May 20, 2025 19:06

SirGitsalot approved these changes May 20, 2025

View reviewed changes

SirGitsalot added this pull request to the merge queue May 20, 2025

Merged via the queue into GoogleCloudPlatform:main with commit dec1fdc May 20, 2025
27 checks passed

Add google_beyondcorp_security_gateway_application resource. #13918

Add google_beyondcorp_security_gateway_application resource. #13918

Uh oh!

Conversation

Berro321 commented May 12, 2025

Uh oh!

modular-magician commented May 12, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented May 12, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented May 12, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 12, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 12, 2025

Uh oh!

modular-magician commented May 12, 2025

Uh oh!

modular-magician commented May 12, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented May 12, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 12, 2025

Uh oh!

modular-magician commented May 13, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented May 13, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 13, 2025

Uh oh!

modular-magician commented May 13, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented May 13, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 13, 2025

Uh oh!

modular-magician commented May 13, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented May 13, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 13, 2025

Uh oh!

modular-magician commented May 14, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented May 14, 2025

Tests analytics

Action taken

Add `google_beyondcorp_security_gateway_application` resource. #13918

Add `google_beyondcorp_security_gateway_application` resource. #13918

NickElliot commented May 20, 2025 •

edited

Loading