Skip to content

We shouldn't replace the url if dialogflow_cx_custom_endpoint is set. #13873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

ArtoriaRen
Copy link
Contributor

@ArtoriaRen ArtoriaRen commented May 7, 2025

This commit fixes the issue and adds a test.

dialogflowcx: fixed using `dialogflow_cx_custom_endpoint` with `Flow` 

@github-actions github-actions bot requested a review from trodge May 7, 2025 16:02
Copy link

github-actions bot commented May 7, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 197 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 9 files changed, 197 insertions(+), 30 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 148 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 197 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 9 files changed, 197 insertions(+), 30 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 148 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 29
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dialogflowcx

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDialogflowCXFlow_dialogflowcxFlowCustomEndpointExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXFlow_dialogflowcxFlowCustomEndpointExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 30
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dialogflowcx

🟢 All tests passed!

View the build log

Copy link

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants