Skip to content

Use commit shas instead of branch names in diff comment #13732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Apr 21, 2025

fixes b/384994967

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge
Copy link
Contributor Author

trodge commented Apr 21, 2025

@modular-magician reassign-reviewer

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from NickElliot April 21, 2025 22:11
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Errors

google provider:

  • Failed to read old commit sha from file

google-beta provider:

  • Failed to read old commit sha from file

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1173
Passed tests: 1089
Skipped tests: 84
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1174
Passed tests: 1090
Skipped tests: 84
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

This reverts commit b159aae.
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge added this pull request to the merge queue Apr 28, 2025
Merged via the queue into GoogleCloudPlatform:main with commit c47c044 Apr 28, 2025
21 checks passed
@trodge trodge deleted the magician-comment-sha branch April 28, 2025 23:55
trodge added a commit that referenced this pull request Apr 29, 2025
@trodge trodge restored the magician-comment-sha branch April 29, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants