Skip to content

Add response_type to google_identity_platform_oauth_idp_config #13690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

pashanka
Copy link
Contributor

@pashanka pashanka commented Apr 16, 2025

Fix hashicorp/terraform-provider-google#9385

Adding new field to the resource that's available in API, but not in TF.
API Documentation - https://cloud.google.com/identity-platform/docs/reference/rest/v2/projects.oauthIdpConfigs#oauthresponsetype

identityplatform: Added `response_type` field to `google_identity_platform_oauth_idp_config`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 133 insertions(+))
google-beta provider: Diff ( 5 files changed, 133 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 17
Passed tests: 13
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages
  • identityplatform

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIdentityPlatformOauthIdpConfig_identityPlatformOauthIdpConfigBasicExample
  • TestAccIdentityPlatformOauthIdpConfig_identityPlatformOauthIdpConfigUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIdentityPlatformOauthIdpConfig_identityPlatformOauthIdpConfigBasicExample [Debug log]
TestAccIdentityPlatformOauthIdpConfig_identityPlatformOauthIdpConfigUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 133 insertions(+))
google-beta provider: Diff ( 5 files changed, 133 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 17
Passed tests: 15
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • identityplatform

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 133 insertions(+))
google-beta provider: Diff ( 5 files changed, 133 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 17
Passed tests: 15
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • identityplatform

🟢 All tests passed!

View the build log

@pashanka pashanka marked this pull request as ready for review April 16, 2025 13:15
@github-actions github-actions bot requested a review from trodge April 16, 2025 13:16
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@trodge trodge added this pull request to the merge queue Apr 22, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 3d75876 Apr 22, 2025
25 checks passed
paridhishah18 pushed a commit to paridhishah18/magic-modules that referenced this pull request Apr 22, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Apr 26, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to change grant type in google_identity_platform_oauth_idp_config
3 participants