Skip to content

Added VCP test for IAP integration in cloudrun v1 #13574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2025

Conversation

bryan0515
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


Added VCR test for IAP integration in google_cloud_run_service (beta).

This PR is cloned from #13179.

@github-actions github-actions bot requested a review from slevenick April 7, 2025 21:47
Copy link

github-actions bot commented Apr 7, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 24 insertions(+))
google-beta provider: Diff ( 3 files changed, 157 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 34
Passed tests: 26
Skipped tests: 6
Affected tests: 2

Click here to see the affected service packages
  • cloudrun

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunService_cloudRunServiceIapExample
  • TestAccCloudRunService_cloudRunServiceIap_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceIapExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceIap_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 25 insertions(+))
google-beta provider: Diff ( 3 files changed, 159 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 34
Passed tests: 26
Skipped tests: 6
Affected tests: 2

Click here to see the affected service packages
  • cloudrun

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunService_cloudRunServiceIapExample
  • TestAccCloudRunService_cloudRunServiceIap_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceIapExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceIap_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 25 insertions(+))
google-beta provider: Diff ( 3 files changed, 159 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 34
Passed tests: 26
Skipped tests: 6
Affected tests: 2

Click here to see the affected service packages
  • cloudrun

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunService_cloudRunServiceIapExample
  • TestAccCloudRunService_cloudRunServiceIap_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceIapExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceIap_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 25 insertions(+))
google-beta provider: Diff ( 3 files changed, 161 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 34
Passed tests: 27
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • cloudrun

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunService_cloudRunServiceIap_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceIap_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the launch stage annotation is behaving strangely. Are you able to run this test successfully locally?

@github-actions github-actions bot requested a review from slevenick April 9, 2025 23:29
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 25 insertions(+))
google-beta provider: Diff ( 3 files changed, 160 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 34
Passed tests: 27
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • cloudrun

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunService_cloudRunServiceIap_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceIap_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@slevenick slevenick added this pull request to the merge queue Apr 10, 2025
Merged via the queue into GoogleCloudPlatform:main with commit fec4a1e Apr 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants