Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify recommendation for simple map types #13551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Apr 4, 2025

Fixes b/385136052

KeyValuePairs is strictly defined to mean string -> string, so for other simple map types like string -> int, we will recommend the Map type.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@roaks3 roaks3 requested review from a team and rileykarson and removed request for a team April 4, 2025 19:14
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants