feat(LbTrafficExtension): Add LBTrafficExtension metadata support #13549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GCP LbTrafficExtension supports to give an object of metadata on setup. This behaviour shall be added with this change. You can setup an loadbalancer traffic extension with a `traffic.yml` like this: ```yaml name: queueit-traffic-extension forwardingRules: - https://www.googleapis.com/compute/v1/projects/[PROJECT]/regions/global/forwardingRules/[GCP_FORWARD_RULE] loadBalancingScheme: EXTERNAL_MANAGED extensionChains: - name: "chain1" matchCondition: celExpression: 'request.host = 'example.com' extensions: - name: 'cloud-connector' authority: [AUTHORITY] service: https://www.googleapis.com/compute/v1/projects/[PROJECT]/regions/global/backendServices/[BACKEND_SERVICE] failOpen: true timeout: 1s supportedEvents: - REQUEST_HEADERS - REQUEST_BODY - RESPONSE_HEADERS metadata: {"customerId": "test"} ``` Which will be added to metadata in the traffic service extension. The metadata object need to be a JSON object to be valid. Afterwards the command: ```bash $ gcloud service-extensions lb-traffic-extensions import test-traffic-extension --source=traffic.yaml --location=global ``` will successfully create an extension including the metadata.
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GCP LbTrafficExtension supports to give an object of metadata on setup. This behaviour shall be added with this change.
You can setup an loadbalancer traffic extension with a
traffic.ymllike this:Which will be added to metadata in the traffic service extension. The metadata object need to be a JSON object to be valid. Afterwards the command:
will successfully create an extension including the metadata.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.