-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support new output-only field dns_names for Cloud SQL instances #13542
base: main
Are you sure you want to change the base?
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Tests analyticsTotal tests: 107 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the test failed. Is this new field supported now?
@@ -1000,6 +1000,28 @@ is set to true. Defaults to ZONAL.`, | |||
Computed: true, | |||
Description: `The dns name of the instance.`, | |||
}, | |||
"dns_names": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a field dns_name
. What is the difference between these two fields, dns_name
and dns_names
?
Also, I don't see this field in the API documentation: https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1/instances
@@ -575,6 +575,8 @@ connection strings. For example, when connecting with [Cloud SQL Proxy](https:// | |||
|
|||
* `dns_name` - The DNS name of the instance. See [Connect to an instance using Private Service Connect](https://cloud.google.com/sql/docs/mysql/configure-private-service-connect#view-summary-information-cloud-sql-instances-psc-enabled) for more details. | |||
|
|||
* `dns_names` - The list of DNS names used by this instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nested fields of this field also need to be listed.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.