Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigqueryconnection: added password_wo write-only field in google_bigquery_connection resource #13541

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Apr 3, 2025

Passing Tests:

󰀵 mau  …/terraform-provider-google   main $!   v1.23.4   14:56   envchain GCLOUD make test TEST=./google/services/bigqueryconnection TESTARGS='--run TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekPasswordWoExample'
sh -c "'/Users/mau/Dev/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
go test --run TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekPasswordWoExample -timeout=30s ./google/services/bigqueryconnection
ok      github.com/hashicorp/terraform-provider-google/google/services/bigqueryconnection       1.861s

󰀵 mau  …/terraform-provider-google   main $!   v1.23.4   14:57   envchain GCLOUD make test TEST=./google/services/bigqueryconnection TESTARGS='--run TestAccBigqueryConnectionConnection_bigqueryConnectionBasic_cmek_wo'               
sh -c "'/Users/mau/Dev/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
go test --run TestAccBigqueryConnectionConnection_bigqueryConnectionBasic_cmek_wo -timeout=30s ./google/services/bigqueryconnection
ok      github.com/hashicorp/terraform-provider-google/google/services/bigqueryconnection       1.262s

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigqueryconnection: added `password_wo` write-only field and `password_wo_version` field in `google_bigquery_connection` resource

@BBBmau BBBmau changed the title support write-only password field in cloudsql.credential bigqueryconnection: added password_wo write-only field in google_bigquery_connection resource Apr 3, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 331 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 5 files changed, 331 insertions(+), 27 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 140 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 13
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • bigqueryconnection
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigqueryConnectionConnection_bigqueryConnectionBasic_cmek_wo

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekPasswordWoExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekPasswordWoExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 331 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 5 files changed, 331 insertions(+), 27 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 140 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 13
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • bigqueryconnection
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigqueryConnectionConnection_bigqueryConnectionBasic_cmek_wo

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekPasswordWoExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekPasswordWoExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 322 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 5 files changed, 322 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 140 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 13
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • bigqueryconnection
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigqueryConnectionConnection_bigqueryConnectionBasic_cmek_wo

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekPasswordWoExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekPasswordWoExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 325 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 5 files changed, 325 insertions(+), 20 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 140 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 13
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • bigqueryconnection
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigqueryConnectionConnection_bigqueryConnectionBasic_cmek_wo

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekPasswordWoExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekPasswordWoExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@BBBmau
Copy link
Collaborator Author

BBBmau commented Apr 4, 2025

Tests analytics

Total tests: 18 Passed tests: 13 Skipped tests: 4 Affected tests: 1

Click here to see the affected service packages

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigqueryConnectionConnection_bigqueryConnectionBasic_cmek_wo

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
Get to know how VCR tests work

Ran on TeamCity Build with Test passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants