Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Account Connector resource for Developer Connect #13534

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ihnarayanan
Copy link
Contributor

fixes hashicorp/terraform-provider-google#22069

developerconnect: added new resource `google_developer_connect_account_connector` resource (ga)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1859 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1859 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 145 insertions(+))
Open in Cloud Shell: Diff ( 20 files changed, 550 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_account_connector (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_account_connector" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 17
Skipped tests: 0
Affected tests: 10

Click here to see the affected service packages
  • developerconnect

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGithubExample
  • TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGithubUpdate
  • TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGitlabExample
  • TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGitlabUpdate
  • TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGoogleExample
  • TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGoogleUpdate
  • TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorRovoExample
  • TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorRovoUpdate
  • TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorSentryExample
  • TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorSentryUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGithubExample [Debug log]
TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGithubUpdate [Debug log]
TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGitlabExample [Debug log]
TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGitlabUpdate [Debug log]
TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGoogleExample [Debug log]
TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorGoogleUpdate [Debug log]
TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorRovoExample [Debug log]
TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorRovoUpdate [Debug log]
TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorSentryExample [Debug log]
TestAccDeveloperConnectAccountConnector_developerConnectAccountConnectorSentryUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1859 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1859 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 145 insertions(+))
Open in Cloud Shell: Diff ( 20 files changed, 550 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_account_connector (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_account_connector" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 27
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • developerconnect

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1859 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1859 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 145 insertions(+))
Open in Cloud Shell: Diff ( 20 files changed, 550 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_account_connector (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_account_connector" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 27
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • developerconnect

🟢 All tests passed!

View the build log

@ihnarayanan ihnarayanan marked this pull request as ready for review April 3, 2025 21:29
Copy link

github-actions bot commented Apr 3, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from rileykarson April 3, 2025 21:30
@github-actions github-actions bot requested a review from rileykarson April 4, 2025 18:30
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1820 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1820 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 135 insertions(+))
Open in Cloud Shell: Diff ( 20 files changed, 550 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 27
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • developerconnect

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Account Connector resource for Developer Connect
3 participants