Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed set_computed_name post_create for products a-d #13532

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

melinath
Copy link
Member

@melinath melinath commented Apr 3, 2025

Part of hashicorp/terraform-provider-google#22214 - this should be duplicated code, because we already set name automatically if it's required.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 108 deletions(-))
google-beta provider: Diff ( 6 files changed, 108 deletions(-))

@modular-magician modular-magician requested a review from wj-chen April 3, 2025 18:32
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • bigquerydatatransfer
  • cloudidentity
  • dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudIdentityGroup

Get to know how VCR tests work

Copy link
Member

@wj-chen wj-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes to BQ resource.

@melinath
Copy link
Member Author

melinath commented Apr 3, 2025

@modular-magician reassign-reviewer

Copy link

github-actions bot commented Apr 3, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from ScottSuarez April 3, 2025 19:12
@modular-magician
Copy link
Collaborator

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants