Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example and test to showcase count increase/decrease for backend service #13531

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

maxi-cit
Copy link
Contributor

@maxi-cit maxi-cit commented Apr 3, 2025

part of: hashicorp/terraform-provider-google#6376

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Added example and test for dynamic backend count for `google_compute_region_backend_service`

@github-actions github-actions bot requested a review from zli82016 April 3, 2025 17:54
Copy link

github-actions bot commented Apr 3, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/compute-l7-load-balancer and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 3, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 268 insertions(+))
google-beta provider: Diff ( 3 files changed, 268 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 144 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1160
Passed tests: 1079
Skipped tests: 79
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionBackendService_regionBackendServiceDynamicBackendCountExample
  • TestAccComputeRegionBackendService_withDynamicBackendCount

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_withDynamicBackendCount [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceDynamicBackendCountExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 4, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 190 insertions(+))
google-beta provider: Diff ( 2 files changed, 190 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1159
Passed tests: 1080
Skipped tests: 79
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@github-actions github-actions bot requested a review from zli82016 April 5, 2025 04:55
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/compute-l7-load-balancer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants