-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for NAT64 when configuring Router NAT #13522
base: main
Are you sure you want to change the base?
Added support for NAT64 when configuring Router NAT #13522
Conversation
… compute RouterNat; - Added dns64Config field to dns Policy;
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1208 Click here to see the affected service packages
Action takenFound 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
@@ -103,6 +103,18 @@ properties: | |||
update_url: 'projects/{{project}}/policies/{{name}}' | |||
update_verb: 'PATCH' | |||
default_value: "Managed by Terraform" | |||
- name: 'dns64Config' | |||
type: NestedObject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type: NestedObject | |
type: NestedObject | |
default_from_api: true |
|
||
acctest.VcrTest(t, resource.TestCase{ | ||
PreCheck: func() { acctest.AccTestPreCheck(t) }, | ||
ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t), | |
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t), |
& remove google-beta
from test configs- the implicit google
provider will be the beta provider inside these tests. We only use the specific beta factory for example tests so the docs use the beta provider!
- Removed google-beta provider usage in Nat64Config test;
Adds
sourceSubnetworkIpRangesToNat64
andnat64Subnetwork
fields tocompute
RouterNat, allowing the support for public Router NAT services with NAT64 enabled.Also adds
dns64Config
field todns
Policy, allowing the configuration of DNS64 server policies, required when using NAT64.Fixes: #22116
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.