Handle custom decoders as part of setting fields in post_create

[melinath]

#12939 started triggering generation of post-create code, but it missed adding support for decoders (which are already used by the equivalent code for pulling computed fields from operation responses.) I also added (harmless at the time) setting of fields for resources that use PollAsync on create.

Decoder support is necessary to properly handle some resources, like bigqueryanalyticshub_listing_subscription. In this specific case, we do end up just moving some code around from one custom code template to another; however, this may reduce the need for post_create custom code on other resources as well.

However, adding decoder support means that we need to stop running this code immediately after create for PollAsync resources (because the decoder returns nil until the resource exists). But we can't just remove setting of id format fields in post-create either, because some resources were relying on it from before #12939.

Since the logic for doing the setting is the same regardless, I factored it out into a separate generated function that can get called in the appropriate part of Create whether it's not async or uses poll async.

(I think we should use the same function for setting id format fields on post-create for OpAsync as well - it's currently still relying on "identity" fields - but I'm leaving that for a separate PR.)

Part of hashicorp/terraform-provider-google#22214

Fixed hashicorp/terraform-provider-google#22239

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigqueryAnalyticsHubListingSubscription_bigqueryAnalyticshubListingSubscriptionBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeLargeCustomDictionaryExample [Error message] [Debug log]
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample [Error message] [Debug log]
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample [Error message] [Debug log]
TestAccMonitoringMonitoredProject_projectNumLongForm [Error message] [Debug log]
TestAccMonitoringMonitoredProject_projectNumShortForm [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 248 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 22 files changed, 256 insertions(+), 27 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1522
Passed tests: 1369
Skipped tests: 142
Affected tests: 11

Click here to see the affected service packages

• bigquerydatatransfer
• firestore
• monitoring
• resourcemanager
• storage
• cloudidentity
• compute
• iap
• bigqueryanalyticshub
• containeranalysis
• datalossprevention
• osconfig
• secretmanager
• secretmanagerregional

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataLossPreventionJobTrigger_dlpJobTriggerInspectCustomInfoTypes
• TestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeBasicExample
• TestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeDictionaryExample
• TestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeGroupIndexUpdate
• TestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeLargeCustomDictionaryExample
• TestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeStoredInfoTypeId
• TestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeUpdate
• TestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeWithIdExample
• TestAccMonitoringMetricDescriptor_monitoringMetricDescriptorAlertExample
• TestAccMonitoringMetricDescriptor_monitoringMetricDescriptorBasicExample
• TestAccMonitoringMetricDescriptor_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMonitoringMetricDescriptor_monitoringMetricDescriptorAlertExample [Error message] [Debug log]
TestAccMonitoringMetricDescriptor_monitoringMetricDescriptorBasicExample [Error message] [Debug log]
TestAccMonitoringMetricDescriptor_update [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 223 files changed, 2361 insertions(+), 202 deletions(-))
google-beta provider: Diff ( 246 files changed, 2585 insertions(+), 226 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 94 files changed, 1194 insertions(+), 206 deletions(-))
google-beta provider: Diff ( 102 files changed, 1279 insertions(+), 231 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 87 files changed, 1138 insertions(+), 206 deletions(-))
google-beta provider: Diff ( 95 files changed, 1223 insertions(+), 231 deletions(-))

[melinath]

This isn't working quite right - for example, a few Chronicle resources are no longer having their fields set on post_create after this change.