Skip to content

Add support for Materialized Views #13251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 23, 2025
Merged

Conversation

ron-gal
Copy link
Contributor

@ron-gal ron-gal commented Mar 4, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_bigtable_materialized_view`

@github-actions github-actions bot requested a review from melinath March 4, 2025 15:52
Copy link

github-actions bot commented Mar 4, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 761 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 761 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 81 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 135 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_materialized_view (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_materialized_view" "primary" {
  instance             = # value needed
  materialized_view_id = # value needed
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 761 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 761 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 81 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 135 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_materialized_view (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_materialized_view" "primary" {
  instance             = # value needed
  materialized_view_id = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 0
Skipped tests: 53
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableMaterializedView_basic
  • TestAccBigtableMaterializedView_bigtableMaterializedViewExample
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 0
Skipped tests: 53
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableMaterializedView_basic
  • TestAccBigtableMaterializedView_bigtableMaterializedViewExample
    🟢 All tests passed!

View the build log

@melinath
Copy link
Member

melinath commented Mar 4, 2025

@github-actions github-actions bot requested a review from melinath March 6, 2025 21:22
@modular-magician

This comment was marked as outdated.

4 similar comments
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 768 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 768 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 81 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 135 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_materialized_view (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_materialized_view" "primary" {
  instance             = # value needed
  materialized_view_id = # value needed
}

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarting review clock.

@melinath melinath self-requested a review March 21, 2025 18:25
Copy link

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@melinath
Copy link
Member

Copy link

@GoogleCloudPlatform/terraform-team @melinath This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resetting review clock

@melinath melinath self-requested a review March 28, 2025 16:08
Copy link

github-actions bot commented Apr 2, 2025

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing from queue for now

Copy link

@ron-gal, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@melinath melinath self-requested a review April 22, 2025 23:17
@melinath
Copy link
Member

/gcbrun

@melinath
Copy link
Member

gcbrun doesn't seem to be working at the moment 🤔 but it should be fine to just do a manual test run anyway: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_BIGTABLE/360197

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 776 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 776 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 81 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 136 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 0
Skipped tests: 53
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableMaterializedView_bigtableMaterializedViewExample
  • TestAccBigtableMaterializedView_deletionProtection
    🟢 All tests passed!

View the build log

@melinath
Copy link
Member

tests passed

@rileykarson
Copy link
Member

Hey @ron-gal do you have any idea why we'd get 501 errors from the API last night? The first night these tests passed, but now we're getting the following:

Error: Error creating MaterializedView: googleapi: Error 501: Operation is not implemented, or supported, or enabled.

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Apr 26, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Apr 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 13, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants