-
Notifications
You must be signed in to change notification settings - Fork 2k
Add support for Materialized Views #13251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_bigtable_materialized_view" "primary" {
instance = # value needed
materialized_view_id = # value needed
}
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_bigtable_materialized_view" "primary" {
instance = # value needed
materialized_view_id = # value needed
}
|
Tests analyticsTotal tests: 53 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
Tests analyticsTotal tests: 53 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
mmv1/templates/terraform/examples/bigtable_materialized_view.tf.tmpl
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/bigtable/resource_bigtable_materialized_view_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/bigtable/resource_bigtable_materialized_view_test.go
Outdated
Show resolved
Hide resolved
mmv1/templates/terraform/examples/bigtable_materialized_view.tf.tmpl
Outdated
Show resolved
Hide resolved
mmv1/templates/terraform/examples/bigtable_materialized_view.tf.tmpl
Outdated
Show resolved
Hide resolved
…f.tmpl Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…_materialized_view_test.go Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…f.tmpl Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…f.tmpl Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
4 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_bigtable_materialized_view" "primary" {
instance = # value needed
materialized_view_id = # value needed
}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restarting review clock.
@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @melinath This PR has been waiting for review for 1 week. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resetting review clock
@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing from queue for now
@ron-gal, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
/gcbrun |
gcbrun doesn't seem to be working at the moment 🤔 but it should be fine to just do a manual test run anyway: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_BIGTABLE/360197 |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 53 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
tests passed |
f2af0ac
Hey @ron-gal do you have any idea why we'd get 501 errors from the API last night? The first night these tests passed, but now we're getting the following:
|
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.