Skip to content

Fix compute images in tests #11095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Jul 2, 2024

source_image debian-10 and centos-7 are not supported now.

Release Note Template for Downstream PRs (will be copied)


@zli82016 zli82016 changed the title Fix compute images Fix compute images in tests Jul 2, 2024
@zli82016
Copy link
Member Author

zli82016 commented Jul 2, 2024

/gcbrun

2 similar comments
@zli82016
Copy link
Member Author

zli82016 commented Jul 2, 2024

/gcbrun

@shuyama1
Copy link
Member

shuyama1 commented Jul 2, 2024

/gcbrun

@shuyama1
Copy link
Member

shuyama1 commented Jul 2, 2024

I think the issue is that the community-checker build got cancelled as it's identified as evil somehow and therefore contributor-membership-checker failed to approved the community-checker build as the build is cancelled and couldn't be found.

However, the community-checker shouldn't got cancelled. Let me retry it one more time

/gcbrun

@zli82016
Copy link
Member Author

zli82016 commented Jul 2, 2024

It is working now. Thanks @shuyama1

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Errors

google provider:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

google-beta provider:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

terraform-google-conversion:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

Open in Cloud Shell:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

@zli82016
Copy link
Member Author

zli82016 commented Jul 2, 2024

Oh, got new errors this time.

@zli82016 zli82016 force-pushed the fix-compute-image branch from 9809134 to 86d0f33 Compare July 2, 2024 18:06
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Errors

google provider:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

google-beta provider:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

terraform-google-conversion:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

Open in Cloud Shell:

  • Failed to clone repo at new branch
  • Failed to clone repo at old branch

@shuyama1
Copy link
Member

shuyama1 commented Jul 2, 2024

#11097 is merged. Re-run the checks

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 29 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 21 files changed, 47 insertions(+), 47 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1032
Passed tests: 935
Skipped tests: 73
Affected tests: 24

Click here to see the affected service packages
  • apphub
  • compute
  • networkservices

Action taken

Found 24 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApphubWorkload_apphubWorkloadBasicExample
  • TestAccApphubWorkload_apphubWorkloadFullExample
  • TestAccApphubWorkload_apphubWorkloadUpdate
  • TestAccDataSourceApphubDiscoveredWorkload_basic
  • TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate
  • TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample
  • TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample
  • TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample
  • TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata
  • TestAccComputeInstanceFromMachineImage_basic
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImage_maxRunDuration
  • TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeInstance_advancedMachineFeatures
  • TestAccComputeTargetInstance_targetInstanceCustomNetworkExample
  • TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample
  • TestAccNetworkServicesLbRouteExtension_update
  • TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample
  • TestAccNetworkServicesLbTrafficExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccApphubWorkload_apphubWorkloadBasicExample[Debug log]
TestAccApphubWorkload_apphubWorkloadFullExample[Debug log]
TestAccApphubWorkload_apphubWorkloadUpdate[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample[Debug log]
TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout[Debug log]
TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata[Debug log]
TestAccComputeInstanceFromMachineImage_basic[Debug log]
TestAccComputeInstanceFromMachineImage_diffProject[Debug log]
TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout[Debug log]
TestAccComputeInstanceFromMachineImage_maxRunDuration[Debug log]
TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript[Debug log]
TestAccComputeInstance_advancedMachineFeatures[Debug log]
TestAccComputeTargetInstance_targetInstanceCustomNetworkExample[Debug log]
TestAccDataSourceApphubDiscoveredWorkload_basic[Debug log]
TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample[Debug log]
TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample[Debug log]
TestAccNetworkServicesLbTrafficExtension_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@zli82016 zli82016 force-pushed the fix-compute-image branch from 86d0f33 to 208217d Compare July 2, 2024 21:13
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 47 insertions(+), 47 deletions(-))
google-beta provider: Diff ( 23 files changed, 69 insertions(+), 69 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1032
Passed tests: 943
Skipped tests: 73
Affected tests: 16

Click here to see the affected service packages
  • apphub
  • compute
  • networkservices

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeInstanceTemplate_enableDisplay
  • TestAccComputeInstanceTemplate_shieldedVmConfig1
  • TestAccComputeInstanceTemplate_shieldedVmConfig2
  • TestAccComputeInstanceTemplate_with18TbScratchDisk
  • TestAccComputeInstanceTemplate_withScratchDisk
  • TestAccComputeInstance_enableDisplay
  • TestAccComputeInstance_shieldedVmConfig
  • TestAccComputeNetworkFirewallPolicyRule_multipleRules
  • TestAccComputeNetworkFirewallPolicyRule_update
  • TestAccComputeRegionInstanceTemplate_enableDisplay
  • TestAccComputeRegionInstanceTemplate_shieldedVmConfig1
  • TestAccComputeRegionInstanceTemplate_shieldedVmConfig2
  • TestAccComputeRegionInstanceTemplate_with18TbScratchDisk
  • TestAccComputeRegionInstanceTemplate_withScratchDisk
  • TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceTemplate_enableDisplay[Debug log]
TestAccComputeInstanceTemplate_shieldedVmConfig1[Debug log]
TestAccComputeInstanceTemplate_shieldedVmConfig2[Debug log]
TestAccComputeInstanceTemplate_with18TbScratchDisk[Debug log]
TestAccComputeInstanceTemplate_withScratchDisk[Debug log]
TestAccComputeInstance_enableDisplay[Debug log]
TestAccComputeInstance_shieldedVmConfig[Debug log]
TestAccComputeRegionInstanceTemplate_enableDisplay[Debug log]
TestAccComputeRegionInstanceTemplate_shieldedVmConfig1[Debug log]
TestAccComputeRegionInstanceTemplate_shieldedVmConfig2[Debug log]
TestAccComputeRegionInstanceTemplate_with18TbScratchDisk[Debug log]
TestAccComputeRegionInstanceTemplate_withScratchDisk[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_update[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@zli82016 zli82016 requested review from a team and roaks3 and removed request for a team July 2, 2024 22:43
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failures all seem unrelated

@zli82016 zli82016 merged commit 29605d3 into GoogleCloudPlatform:main Jul 3, 2024
12 of 13 checks passed
@zli82016 zli82016 deleted the fix-compute-image branch July 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants