Migrate network connectivity spoke from DCL to MMv1

[kalpanda]

Migration of Spoke from DCL to Magic-Modules

Migration of Hub from DCL to Magic-Modules

networkconnectivity: migrated `google_network_connectivity_spoke` from DCL to MMv1

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Errors

google provider:

• Failed to clone repo at new branch
• Failed to clone repo at old branch

google-beta provider:

• Failed to clone repo at new branch
• Failed to clone repo at old branch

terraform-google-conversion:

• Failed to clone repo at new branch
• Failed to clone repo at old branch

Open in Cloud Shell:

• Failed to clone repo at new branch
• Failed to clone repo at old branch

[github-actions]

@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1517 insertions(+), 766 deletions(-))
google-beta provider: Diff ( 7 files changed, 1446 insertions(+), 746 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 299 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 288 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 19
Passed tests: 19
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• networkconnectivity

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[zli82016]

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Hello, @trodge , is this a breaking change?

[trodge]

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Hello, @trodge , is this a breaking change?

No, this is a false positive. Diff suppress functions on the project field have no effect because the field is never read from the API.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1518 insertions(+), 789 deletions(-))
google-beta provider: Diff ( 9 files changed, 1447 insertions(+), 788 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 299 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 288 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 3861
Passed tests: 3464
Skipped tests: 383
Affected tests: 14

Click here to see the affected service packages

All service packages are affected

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRouterBgpPeer_routerPeerRouterAppliance
• TestAccComputeRouterNat_AutoNetworkTier
• TestAccComputeRouterNat_withPrivateNatAndEmptyAction
• TestAccComputeRouterNat_withPrivateNatAndEmptyActionActiveRanges
• TestAccComputeRouterNat_withPrivateNatAndRules
• TestAccComputeRouterPeer_routerApplianceInstance
• TestAccDataSourceArtifactRegistryDockerImage
• TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten
• TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm
• TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten
• TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm
• TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample
• TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample
• TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRouterBgpPeer_routerPeerRouterAppliance[Debug log]
TestAccComputeRouterNat_AutoNetworkTier[Debug log]
TestAccComputeRouterNat_withPrivateNatAndEmptyAction[Debug log]
TestAccComputeRouterNat_withPrivateNatAndEmptyActionActiveRanges[Debug log]
TestAccComputeRouterNat_withPrivateNatAndRules[Debug log]
TestAccComputeRouterPeer_routerApplianceInstance[Debug log]
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten[Debug log]
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm[Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten[Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm[Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample[Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[zli82016]

LGTM. Thanks.

[zli82016]

@trodge, do you mind reviewing the PR again? Thanks.