mockGCP: More fidelity for CloudIdentityMembership mock #4443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingyih The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit ca96d58
into
GoogleCloudPlatform:master
32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
1st commit 7f27152: collect realGCP logs. Triggered a prow job in CL#73200(the -1 is expected, since we start a new pipeline for each run, there's no golden log to compare with. Other than the diff I don't see other errors), realGCP logs located in GCS storage: https://pantheon.corp.google.com/storage/browser/cnrm-prow/pr-logs/pull/cnrm-review.googlesource.com_cnrm/73200/cnrm-test/1915505218699661312/artifacts?e=13802955&mods=pan_ng2&pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))
2nd commit 6a1af10: Update mock server and re-collect mockGCP logs. Only the extra GET group requests after deletion call is missing. I think that's acceptable.
Tests you have done
make ready-prto ensure this PR is ready for review.