feat: add controller, test and mock support for SpeechPhraseSet #4416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyih
force-pushed
the
resource-speech-phraseset
branch
from
b460611 to
5e7ad0b
Compare
|
/assign @maqiuyujoyce |
jingyih
force-pushed
the
resource-speech-phraseset
branch
from
5e7ad0b to
71c0436
Compare
| @@ -5,15 +5,12 @@ X-Goog-Request-Params: name=projects%2F${projectId}%2Flocations%2Fglobal%2Fphras | |||
|
|
|||
| 404 Not Found | |||
| Content-Type: application/json; charset=UTF-8 | |||
| Grpc-Status-Details-Bin: CAUSW1VuYWJsZSB0byBmaW5kIFBocmFzZVNldCBzcGVlY2hwaHJhc2VzZXQtbWluaW1hbC16ZHVqeTV0dmFubXJ0eGkgZnJvbSBwcm9qZWN0IDYwMDEzOTU2NjExNi4a+QEKJHR5cGUuZ29vZ2xlYXBpcy5jb20vdXRpbC5TdGF0dXNQcm90bxLQAQgFEgdnZW5lcmljGltVbmFibGUgdG8gZmluZCBQaHJhc2VTZXQgc3BlZWNocGhyYXNlc2V0LW1pbmltYWwtemR1ank1dHZhbm1ydHhpIGZyb20gcHJvamVjdCA2MDAxMzk1NjYxMTYuKmYLEIbWjScaXRJbVW5hYmxlIHRvIGZpbmQgUGhyYXNlU2V0IHNwZWVjaHBocmFzZXNldC1taW5pbWFsLXpkdWp5NXR2YW5tcnR4aSBmcm9tIHByb2plY3QgNjAwMTM5NTY2MTE2Lgw= | |||
There was a problem hiding this comment.
Non-blocker: Maybe we should clear these headers/fields when recording the golden logs?
| @@ -5,15 +5,12 @@ X-Goog-Request-Params: name=projects%2F${projectId}%2Flocations%2Fglobal%2Fphras | |||
|
|
|||
| 404 Not Found | |||
| Content-Type: application/json; charset=UTF-8 | |||
| Grpc-Status-Details-Bin: CAUSW1VuYWJsZSB0byBmaW5kIFBocmFzZVNldCBzcGVlY2hwaHJhc2VzZXQtbWluaW1hbC16ZHVqeTV0dmFubXJ0eGkgZnJvbSBwcm9qZWN0IDYwMDEzOTU2NjExNi4a+QEKJHR5cGUuZ29vZ2xlYXBpcy5jb20vdXRpbC5TdGF0dXNQcm90bxLQAQgFEgdnZW5lcmljGltVbmFibGUgdG8gZmluZCBQaHJhc2VTZXQgc3BlZWNocGhyYXNlc2V0LW1pbmltYWwtemR1ank1dHZhbm1ydHhpIGZyb20gcHJvamVjdCA2MDAxMzk1NjYxMTYuKmYLEIbWjScaXRJbVW5hYmxlIHRvIGZpbmQgUGhyYXNlU2V0IHNwZWVjaHBocmFzZXNldC1taW5pbWFsLXpkdWp5NXR2YW5tcnR4aSBmcm9tIHByb2plY3QgNjAwMTM5NTY2MTE2Lgw= | |||
| Server: scaffolding on HTTPServer2 | |||
There was a problem hiding this comment.
Non-blocker: Have we seen this value before? I'm curious if this is a special configuration that might impact anything.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maqiuyujoyce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 1f9a727
into
GoogleCloudPlatform:master
32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.