Add troubleshooting suggestion to test log #4342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyih
reviewed
Apr 11, 2025
| @@ -194,7 +194,7 @@ func waitForReadySingleResource(t *Harness, u *unstructured.Unstructured, timeou | |||
| return true, nil | |||
| } | |||
| if u.Object["status"] == nil { | |||
| logger.Info("resource does not yet have status", "kind", u.GetKind(), "name", u.GetName()) | |||
| logger.Info("resource does not yet have status", "kind", u.GetKind(), "name", u.GetName(), "troubleshooting", "if you keep seeing this error message, check if you've imported the service in pkg/controller/direct/register/register.go") | |||
There was a problem hiding this comment.
I believe waitForReadySingleResource is used across all samples, including those with TF and DCL-based controllers. Could this potentially cause confusion?
There was a problem hiding this comment.
Good point. I updated the error message to clarify the suggestion only applies to direct resource.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingyih The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maqiuyujoyce
force-pushed
the
202504-test-hint
branch
from
9479650 to
ec2209a
Compare
google-oss-prow
bot
merged commit c7fa9e1
into
GoogleCloudPlatform:master
32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.