Conductor improvements and switch controllerbuilder to new default model #4267
+296
−423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tweak prompts * Refactor code to move repetitive code under prepareCodebotPrompt (for crd steps) * Add option to run subset of processors in multi-processor step like 21. Rationale is to rerun processors that did not generate output. * --processors=p1,p2,.... * Fix bugs with repetititve steps: * for step 9 where it was running make ready-pr many times * everywhere where changes were not generated
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
barney-s
force-pushed
the
conductor-controller
branch
from
38b1a04 to
abee7f7
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controllerbuilder: switch to new default model
Conductor: Improvements for Type and Mapper generation
crd steps)
21. Rationale is to rerun processors that did not generate output.