Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockGCP&Controller: Resource compute networkedgesecurityservice #4240

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

gemmahou
Copy link
Collaborator

@gemmahou gemmahou commented Apr 2, 2025

Change description

diff base: #4226

Special behavior of this resource:

  1. Error 400: Network Security Policies require Cloud Armor Managed Protection Plus tier and above to use.
    Need to follow this guide to upgrade to enterprise tier.
  2. Only ONE networkedgesecurityservice per region per project is allowed.

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemmahou gemmahou force-pushed the resource-compute-networkedgesecurityservice-controller branch 2 times, most recently from 2933cf5 to 9fce2ca Compare April 4, 2025 00:18
@gemmahou gemmahou force-pushed the resource-compute-networkedgesecurityservice-controller branch from 9fce2ca to 3983780 Compare April 4, 2025 16:32
@gemmahou gemmahou marked this pull request as ready for review April 4, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant