Support types, CRD and mapper for NetworkManagementConnectivityTest #4213
Conversation
maqiuyujoyce
force-pushed
the
resource-networkmanagement-connectivitytest
branch
3 times, most recently
from
35ae076 to
7b3da7f
Compare
|
/assign @jingyih |
| // Requires gke_master_cluster to be set, can't be used simultaneoulsly with | ||
| // ip_address or network. Applicable only to destination endpoint. | ||
| // +kcc:proto:field=google.cloud.networkmanagement.v1.Endpoint.fqdn | ||
| Fqdn *string `json:"fqdn,omitempty"` |
| // +kcc:proto:field=google.cloud.networkmanagement.v1.Endpoint.cloud_sql_instance | ||
| SQLInstanceRef *refsv1beta1.SQLInstanceRef `json:"sqlInstance,omitempty"` | ||
|
|
||
| // TODO: Should be reference. |
There was a problem hiding this comment.
Is this PR still WIP?
(There are a lot of references...)
There was a problem hiding this comment.
It's quite a bit of manual work to make all the reference fields work here and I think it'll be a good use of LLM or the non LLM automation tool to turn the fields into references. So I think want to keep them TODOs here and make them candidate for reference automation.
…ype. WARN: extra files found, committing them.
…files found, committing them.
maqiuyujoyce
force-pushed
the
resource-networkmanagement-connectivitytest
branch
from
7b3da7f to
6929cbd
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingyih The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit de34437
into
GoogleCloudPlatform:master
Change description
Tests you have done
make ready-prto ensure this PR is ready for review.