feat: migrate DataCatalog Taxonomy controller to direct #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
anhdle-sso
changed the title
anhdle-sso
force-pushed
the
resource-datacatalog-taxonomy
branch
from
3d2eaa9 to
8fbd2ed
Compare
anhdle-sso
changed the title
anhdle-sso
force-pushed
the
resource-datacatalog-taxonomy
branch
2 times, most recently
from
3c6d00c to
21fd32f
Compare
|
/hold |
anhdle-sso
force-pushed
the
resource-datacatalog-taxonomy
branch
from
21fd32f to
5bc3e1e
Compare
anhdle-sso
changed the title
|
Is this ready for review? |
1 similar comment
|
Is this ready for review? |
|
@yuwenma please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Fixes #
Tests you have done
make ready-prto ensure this PR is ready for review.