mockGCP: Resource modelarmor template #4125
Conversation
gemmahou
force-pushed
the
resource-modelarmor-template
branch
from
87a6f43 to
4c779bc
Compare
gemmahou
force-pushed
the
resource-modelarmor-template
branch
2 times, most recently
from
4c779bc to
60a2e42
Compare
There was a problem hiding this comment.
Mind explaining why this CRD is changed?
There was a problem hiding this comment.
Ah it's from the generate CRD task I included files in this PR by mistake. Removed
gemmahou
force-pushed
the
resource-modelarmor-template
branch
6 times, most recently
from
f127cbf to
6b19557
Compare
| @@ -0,0 +1,5 @@ | |||
| - pre: gcloud config set api_endpoint_overrides/modelarmor "https://modelarmor.us-central1.rep.googleapis.com/" | |||
There was a problem hiding this comment.
I think we don't need to override the api endpoint. Could you double check?
There was a problem hiding this comment.
Yes, this is a required step specific for this resource, in addition to the regular API enabling: https://cloud.google.com/security-command-center/docs/get-started-model-armor#enable-model-armor
The location specified in the endpoint must match the resource's location, otherwise the API execution will fail.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…xtra files found, committing them. "
gemmahou
force-pushed
the
resource-modelarmor-template
branch
from
4f0cbe2 to
887a62a
Compare
|
/lgtm |
google-oss-prow
bot
merged commit d63ced3
into
GoogleCloudPlatform:master
Change description
Fixes #
Tests you have done
make ready-prto ensure this PR is ready for review.