Support mockgcp for KMSImportJob #4039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqiuyujoyce
force-pushed
the
resource-kms-importjob
branch
from
2ea50ce to
a16940a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Please fix the merge conflict |
maqiuyujoyce
force-pushed
the
resource-kms-importjob
branch
from
a16940a to
eb39393
Compare
|
/lgtm |
maqiuyujoyce
force-pushed
the
resource-kms-importjob
branch
from
eb39393 to
729d08b
Compare
1 task
|
/lgtm |
maqiuyujoyce
force-pushed
the
resource-kms-importjob
branch
from
729d08b to
4ae6be6
Compare
|
/lgtm |
maqiuyujoyce
force-pushed
the
resource-kms-importjob
branch
from
4ae6be6 to
6d84f4f
Compare
…found, committing them"
…, committing them"
maqiuyujoyce
force-pushed
the
resource-kms-importjob
branch
from
6d84f4f to
502ffb1
Compare
|
/lgtm |
google-oss-prow
bot
merged commit b17d0cd
into
GoogleCloudPlatform:master
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Add gcloud test script, HTTP logs and mockgcp for KMSImportJob.
Tests you have done
make ready-prto ensure this PR is ready for review.