Add a workflow to automate config connector release bundle creation #3595
Conversation
xiaoweim
changed the title
xiaoweim
force-pushed
the
automate_release_bundle
branch
8 times, most recently
from
1355c5e to
c0d9546
Compare
xiaoweim
changed the title
|
/assign @yuwenma |
xiaoweim
force-pushed
the
automate_release_bundle
branch
from
c0d9546 to
2b489cb
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -18,6 +18,6 @@ commonLabels: | |||
| commonAnnotations: | |||
| cnrm.cloud.google.com/operator-version: "1.128.0" | |||
| resources: | |||
| - crds.yaml | |||
There was a problem hiding this comment.
Have you tried this in 1.128 release? Mostly I want to make sure if the manager's image is updated to 1.128 (currently it depends on some temporary kustomize patch file).
There was a problem hiding this comment.
For the release script, I have added the correct operator image when generating the manager_image_patch_template.yaml, so the image in the statefulset is updated to the right version.
| on: | ||
| push: | ||
| tags: | ||
| - 'v*' |
There was a problem hiding this comment.
can we change this to only match semver2?
There was a problem hiding this comment.
Sure, I can add expression format for standard versions. I think we do not have to trigger release bundle build for pre-release versions like v1.0.0-alpha.1, v2.0.0-beta.1, v1.0.0-rc.1.
xiaoweim
force-pushed
the
automate_release_bundle
branch
from
2b489cb to
7a0bf64
Compare
| @@ -18,6 +18,6 @@ commonLabels: | |||
| commonAnnotations: | |||
| cnrm.cloud.google.com/operator-version: "1.128.0" | |||
| resources: | |||
| - crds.yaml | |||
There was a problem hiding this comment.
For the release script, I have added the correct operator image when generating the manager_image_patch_template.yaml, so the image in the statefulset is updated to the right version.
| on: | ||
| push: | ||
| tags: | ||
| - 'v*' |
There was a problem hiding this comment.
Sure, I can add expression format for standard versions. I think we do not have to trigger release bundle build for pre-release versions like v1.0.0-alpha.1, v2.0.0-beta.1, v1.0.0-rc.1.
xiaoweim
force-pushed
the
automate_release_bundle
branch
from
7a0bf64 to
1fea0bb
Compare
xiaoweim
force-pushed
the
automate_release_bundle
branch
2 times, most recently
from
4cb5edd to
28e2e2e
Compare
xiaoweim
force-pushed
the
automate_release_bundle
branch
from
28e2e2e to
3c0e661
Compare
xiaoweim
force-pushed
the
automate_release_bundle
branch
from
3c0e661 to
0a75d3b
Compare
There was a problem hiding this comment.
/hold
The code itself looks good but we cannot merge it now because everyone has permission to "create the release bundle" by pushing a trigger (git tag). @xiaoweim Could you share the overall plan on how to deal with this issue?
Change description
Add a workflow to automate release bundle creation on every git tag version push. (version starts with a "v")
TODO: we should restrict the users that can do git push tag.
Tests you have done
Tested the workflow: https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/13146252562/job/36684918680?pr=3595
make ready-prto ensure this PR is ready for review.